login functions device flow proof-of-concept #498
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Git2Gus App is installed but the |
peternhale
requested changes
Sep 26, 2022
| static examples = messages.getMessages('examples'); | ||
|
|
||
| static flags = { | ||
| 'instance-url': Flags.string({ |
There was a problem hiding this comment.
considering using flags.url as alternative to flags.string
| devHub: true, | ||
| }); | ||
| } | ||
| await authInfo.save(); |
There was a problem hiding this comment.
Save() is also called in the handle function.
Co-authored-by: peternhale <[email protected]>
|
@peternhale Thanks for the feedback. For the time being, this PR only exists as a conversation starter for how we can do an interactive functions login in a containerized dev environment. There are some questions to work out before we think about merging, like:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is a proof-of-concept that adds the
sf login functions devicecommand. This command uses the Salesforce device flow to log in to an org, then uses the resulting token as the subject token for the functions API token exchange.The code borrows heavily from patterns established by existing commands
sfdx auth:device:loginandsf login functions jwt.What issues does this PR fix or reference?
W-11635097